Adopt AEP 231 - Batch Get #177
Merged
+250
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofrankel
requested changes
Apr 26, 2024
Co-authored-by: Richard Frankel <[email protected]>
|
@rofrankel Please re-review. |
rofrankel
previously requested changes
May 10, 2024
Co-authored-by: Richard Frankel <[email protected]>
|
@rofrankel Thanks for the re-review. I addressed your comments and asked for a new review. |
|
I made the updates we discussed three weeks ago. Please re-review and let me know if there is any additional feedback. |
rofrankel
reviewed
Sep 20, 2024
|
@rofrankel Thanks for the comments. I've addressed or answered all that I could. I will need help on the proto definition of the response. I will tag you for re-review. |
toumorokoshi
requested changes
Oct 18, 2024
Co-authored-by: Yusuke Tsutsumi <[email protected]>
Co-authored-by: Yusuke Tsutsumi <[email protected]>
|
Thank you for the review and suggestions @toumorokoshi. I accepted all these. Is there anything else to do or can we merge this now? |
toumorokoshi
approved these changes
Oct 25, 2024
toumorokoshi
dismissed
rofrankel’s stale review
@toumorokoshi is taking over the review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt AEP 231 - Batch Get
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)Additional checklist for a new AEP
guidelines are met.
Document structure
guidelines are met.
💝 Thank you!